Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length

JoomlaTune Support Forum    JComments component    Integration with third-party extensions    K2 JComments    Topic: slight change for compatibility
Pages: [1]   Go Down
  Print  
Author Topic: slight change for compatibility  (Read 5599 times)
0 Members and 1 Guest are viewing this topic.
gobezu
Newbie
*

Karma: 0
Offline Offline

Posts: 5



WWW
« on: March 19, 2012, 08:58:42 »

Thank you for the new release, all is working fine.

May I suggest the following addition that would make it soo much easier to work when overriding classes through the excellent JLoader.


Code:
if (!class_exists('K2HelperRoute')) require_once($routerHelper);

in

Code:
site/components/com_jcomments/plugins/com_k2.plugin.php

This would allow other developers to override classes.

Thank you!
Logged

http://jproven.com
Heart
Newbie
*

Karma: 0
Offline Offline

Posts: 6


« Reply #1 on: March 19, 2012, 14:11:53 »

check your "in" line again please. Is this really correct!?
Logged
gobezu
Newbie
*

Karma: 0
Offline Offline

Posts: 5



WWW
« Reply #2 on: March 20, 2012, 04:50:52 »

site stands for your sites root folder (most likely ...public_html)

just look for the file com_k2.plugin.php which is bound to be unique, at least in the context of jcomments
Logged

http://jproven.com
Heart
Newbie
*

Karma: 0
Offline Offline

Posts: 6


« Reply #3 on: March 20, 2012, 14:41:17 »

Oh, I misunderstood you then. So you mean change
Code:
$routerHelper = JPATH_SITE.'/components/com_k2/helpers/route.php';
if (is_file($routerHelper)) {
require_once($routerHelper);
to
Code:
$routerHelper = JPATH_SITE.'/components/com_k2/helpers/route.php';
if (is_file($routerHelper)) {
                        if (!class_exists('K2HelperRoute')) require_once($routerHelper);
Logged
gobezu
Newbie
*

Karma: 0
Offline Offline

Posts: 5



WWW
« Reply #4 on: March 20, 2012, 15:16:49 »

Correct understood and the change to be made is to be located in the file:

components/com_jcomments/plugins/com_k2.plugin.php
Logged

http://jproven.com
gobezu
Newbie
*

Karma: 0
Offline Offline

Posts: 5



WWW
« Reply #5 on: March 23, 2012, 08:08:38 »

bumping up this one and wondering if this slight change suggestion is considered or will be part of future updates?
thank you!
Logged

http://jproven.com
smart
Administrator
Hero Member
*****

Karma: 176
Offline Offline

Gender: Male
Posts: 1843



WWW
« Reply #6 on: May 30, 2012, 17:42:08 »

Ok, I will include this modification in next update.
Logged

If you use JComments, please post a rating and a review at the Joomla! Extensions Directory
Pages: [1]   Go Up
  Print  
JoomlaTune Support Forum    JComments component    Integration with third-party extensions    K2 JComments    Topic: slight change for compatibility
 
Jump to: