Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length

JoomlaTune Support Forum    JComments component    Bug-reports    Topic: VIP BUG fast response needed
Pages: [1]   Go Down
  Print  
Author Topic: VIP BUG fast response needed  (Read 1872 times)
0 Members and 2 Guests are viewing this topic.
genesis26
Newbie
*

Karma: 0
Offline Offline

Posts: 3


Email
« on: March 30, 2011, 04:51:01 »

We need URGENTLY a code to fix the width of comments - no matter what the content is!

At the moment it is possible, that user can fill in special signs / charactars, that destroys the layout of JOOMLA sites.

Problem: If users fill in excessive special characters, the layout will dynamically extend the comments to the left. Result: the whol layout is destroyed! (Also by putting in too big images)

U can destroy the site by excessivly typing ??  or ..............................  or !!!!!!!!!!!!!!!!!!!!  for example.

For special characters the forced break doesn't work. It works only for normal charactors.

Another problem:

posting a megalong artificial link also destroys the page.  Normally links are shortened - but if links that are artifically megalong (put in by bad boys) the site layout goes bust. EXAMPLE:

This kind of links are automatically shortened:
http://community.nytimes.com/comments/www.nytimes.com/2011/03/30/world/asia/30japan.html?sort=oldest&offset=2#preview

Links like this are NOT shortened:

www.asdfadfasdfadsdfasdfasdfasdfasdfasdfasdfasdfasdfasdfdfasdfasdfsadfasdfasdfsdafasdfasdfasdfasdfasdfasdggdfhhjjkklklghlklöhkljklzuizugfzgggggggggggggggjjjjjjjjjjjjjjjjllllllllllllllllllll.com

so everybody who know this, can destroy a page.

U should implement a better break force
After a certain number of EVERY character a break MUST be forced. No matter it it s letters like abcdefg  etc. or special codes like: !?=))((//&&&

The excessive USE of special Codes MUST be prohibited. So NO: !!!!!!!""""""""""§§§§§§§§§§$$$$$$$$%########+++++++`````````````´´´´´´´´´´´´'''''''''''''' etc


etc.

Furthermore - if bad people use special characters, problem gets even worse, cause the databank goes down.

Some Speciael characters like  ````´´´´´´´''''''  makes the databank going down. Result: whole site down.

u must EXCLUDE the permission of typing in these special charactors in an excessive way.

Even more it ist important, that forced breaks are also enabled on special charactors like  !!!!!!!!! ?? ########## (((((((((( ))))))) and so on



Conclusion:

1. Prohibit typing more than one '`´ etc - cause it makes databank problems.
2. We need a code, that fixes the width of the comments, no matter what the content is.






« Last Edit: April 02, 2011, 17:30:55 by genesis26 » Logged
smart
Administrator
Hero Member
*****

Karma: 160
Offline Offline

Gender: Male
Posts: 2559



WWW
« Reply #1 on: April 19, 2011, 06:30:13 »

I don't see any harm from chars like ", ' or ` - they are correctly processed by JComments. Regarding long urls - you're right.

I can suggest simple fix.

Open /components/com_jcomments/jcomments.php and replace:
Code: (php)
$link_text = $shortLink;
}
with
Code: (php)
$link_text = wordwrap($shortLink, $link_maxlength, ' ', true);
} else {
$link_text = wordwrap($link_text, $link_maxlength, ' ', true);
}


Logged

If you use JComments, please post a rating and a review at the Joomla! Extensions Directory
Pages: [1]   Go Up
  Print  
JoomlaTune Support Forum    JComments component    Bug-reports    Topic: VIP BUG fast response needed
 
Jump to: