Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length

JoomlaTune Support Forum    JComments component    Suggestions, Wishlists & Feature Requests    Topic: RTL languages support
Pages: [1]   Go Down
  Print  
Author Topic: RTL languages support  (Read 5218 times)
0 Members and 2 Guests are viewing this topic.
Eldad
Newbie
*

Karma: 0
Offline Offline

Posts: 5


Email
« on: January 29, 2010, 07:13:00 »

Hi, I'm the guy that commented regarding RTL languages support in the JED Jcomment page.
First- let me say I'm really impressed both by the great job you've made, and by the attitude you show by constantly striving to improve you're product.
As for RTL languages- as far as I know, there are 2: Hebrew and Arabic (Arabic letters are also used also for writing other languages, such as Persian for example).

As for making the addon RTL- It's actually really really easy. I simply manipulated the style.css file and changed some of the lines. I've attached the file I made so you can see the changes. Best way to make this, I figure, is to make the RTL selectable as a parameter from the backend.
You may notice I didn't really finish the work- the emoticons are still sticking to the left. I'm a bit short of time (and admittedly also lazy) so I didn't finish the work completly. I must also admit that I never bothered to translate the module, but used it in the english version, as it was quite sufficient for me.

Here's a link to an article on my site with some comments:
http://long.co.il/index.php?option=com_content&view=article&id=195:generation-iv-nuclear-reactor-initia-generation-iv-nuclear-reactor-initiative&catid=51:2009-09-02-11-35-38&Itemid=73

you can see the RTL works pretty smoothly, exept for the emoticons.
I hope you find this post usefull, if you need some help encorporating this I'll be glad to help- I was touched by you're enthusiastic reply in the JED page. Keep up the good work!

BTW-
I do believe that there is some demand for your addon to be RTL capable, as I have already recieved a couple of requests for the RTL adjusted file.

* style.css (13.64 KB - downloaded 302 times.)
Logged
smart
Administrator
Hero Member
*****

Karma: 146
Offline Offline

Gender: Male
Posts: 2579



WWW
« Reply #1 on: January 29, 2010, 16:51:00 »

Thanks alot, I've attached modified file - please check it on your site. It contain changes for BBCodes, vote buttons, send button and other elements what hasn't right alignment yet.

* style.css (13.64 KB - downloaded 323 times.)
Logged

If you use JComments, please post a rating and a review at the Joomla! Extensions Directory
Eldad
Newbie
*

Karma: 0
Offline Offline

Posts: 5


Email
« Reply #2 on: January 30, 2010, 05:09:44 »

Works like a charm.
Are you going to add RTL as a selectable option from the backend?

Anyhow, if you're interested, I'll start working on translating the front end plugin to Hebrew when I have the time, so you can also add it to the language support. Once you have an RTL option, translating into Arabic, Persian and other such languages should be pretty easy.
Logged
smart
Administrator
Hero Member
*****

Karma: 146
Offline Offline

Gender: Male
Posts: 2579



WWW
« Reply #3 on: January 30, 2010, 05:12:12 »

I've already added RTL support to upcoming version (additional CSS file is used if current language is RTL)
Logged

If you use JComments, please post a rating and a review at the Joomla! Extensions Directory
Eldad
Newbie
*

Karma: 0
Offline Offline

Posts: 5


Email
« Reply #4 on: January 30, 2010, 09:04:33 »

 Cheesy Cheesy Cheesy Cheesy Cheesy Cheesy Cheesy
you're pretty thorough Smiley
When/if I make a real translation I'll post it here as well.
Logged
omar
Newbie
*

Karma: 0
Offline Offline

Posts: 3


« Reply #5 on: February 27, 2010, 23:55:02 »

Thank you , But the file is not CSS valid (there is one error),
use thins link to check it:
http://jigsaw.w3.org/css-validator/#validate_by_upload

can you fix it please?

thank you
Logged
Eldad
Newbie
*

Karma: 0
Offline Offline

Posts: 5


Email
« Reply #6 on: February 28, 2010, 04:21:36 »

Omar, what is the problem you're having?

And now some some updates:
First, in order to be a real RTL, you also need to move the writing near the boxes from right to left. While I didn't really care about it, someone who asked me about the RTL conversion because of the message I left in JEDI told me about it.

Also, I have an hebrew translation. I'm not sure who made it originally, but I got it from another joomla! builder and adjusted it, so you can add this as well to the next version.

* he-IL.com_jcomments.ini (23.34 KB - downloaded 309 times.)
Logged
omar
Newbie
*

Karma: 0
Offline Offline

Posts: 3


« Reply #7 on: February 28, 2010, 11:12:23 »

Omar, what is the problem you're having?

And now some some updates:
First, in order to be a real RTL, you also need to move the writing near the boxes from right to left. While I didn't really care about it, someone who asked me about the RTL conversion because of the message I left in JEDI told me about it.

Also, I have an hebrew translation. I'm not sure who made it originally, but I got it from another joomla! builder and adjusted it, so you can add this as well to the next version.


Thank you
Logged
smart
Administrator
Hero Member
*****

Karma: 146
Offline Offline

Gender: Male
Posts: 2579



WWW
« Reply #8 on: March 09, 2010, 23:34:14 »

Thank you , But the file is not CSS valid (there is one error),
could you point me that error do you mean?
Logged

If you use JComments, please post a rating and a review at the Joomla! Extensions Directory
wael.salman
Newbie
*

Karma: 0
Offline Offline

Posts: 3


« Reply #9 on: July 02, 2010, 00:08:29 »

Great Work :-)
Logged
Pages: [1]   Go Up
  Print  
JoomlaTune Support Forum    JComments component    Suggestions, Wishlists & Feature Requests    Topic: RTL languages support
 
Jump to: